PMD Results

The following document contains the results of PMD 3.7.

Files

zombies/engine/cards/Card.java

ViolationLine
Each class should declare at least one constructor8 - 52
Use explicit scoping instead of the default package private level27

zombies/engine/cards/Weapon.java

ViolationLine
Each class should declare at least one constructor7 - 39
Use explicit scoping instead of the default package private level10
Use explicit scoping instead of the default package private level13
Use explicit scoping instead of the default package private level16
Use explicit scoping instead of the default package private level19
Use explicit scoping instead of the default package private level22
Use explicit scoping instead of the default package private level25
Use explicit scoping instead of the default package private level29

zombies/engine/cards/WeaponSplashMap.java

ViolationLine
Use explicit scoping instead of the default package private level15
Use explicit scoping instead of the default package private level16
Use explicit scoping instead of the default package private level17
Use explicit scoping instead of the default package private level19
Use explicit scoping instead of the default package private level20
A method should have only one exit point, and that should be the last statement in the method92

zombies/engine/cards/Item.java

ViolationLine
Each class should declare at least one constructor3 - 10

zombies/engine/cards/Event.java

ViolationLine
Each class should declare at least one constructor3 - 10

zombies/engine/map/Tiles.java

ViolationLine
Each class should declare at least one constructor9 - 102

zombies/engine/map/GameMap.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method95

zombies/engine/map/MapLoader.java

ViolationLine
Each class should declare at least one constructor26 - 255
Avoid assigments in operands122 - 136

zombies/engine/critter/Creature.java

ViolationLine
Each class should declare at least one constructor9 - 128

zombies/engine/critter/Human.java

ViolationLine
It is a good practice to call super() in a constructor12 - 19

zombies/engine/critter/Zombie.java

ViolationLine
It is a good practice to call super() in a constructor17 - 25

zombies/util/ImageUtil.java

ViolationLine
Each class should declare at least one constructor14 - 115
A method should have only one exit point, and that should be the last statement in the method29
A method should have only one exit point, and that should be the last statement in the method74
A method should have only one exit point, and that should be the last statement in the method96

zombies/util/PathUtil.java

ViolationLine
Each class should declare at least one constructor12 - 54

zombies/util/xml/XMLTree.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.26
Assigning an Object to null is a code smell. Consider refactoring.52
Assigning an Object to null is a code smell. Consider refactoring.64

zombies/util/xml/XMLTreeHandler.java

ViolationLine
Avoid unnecessary constructors - the compiler will generate these for you30 - 32
Assigning an Object to null is a code smell. Consider refactoring.58

zombies/ZombieConstants.java

ViolationLine
Avoid modifiers which are implied by the context7
Avoid modifiers which are implied by the context8
Avoid modifiers which are implied by the context11
Avoid modifiers which are implied by the context12
Avoid modifiers which are implied by the context13

zombies/gfx/TilesetLoader.java

ViolationLine
Each class should declare at least one constructor24 - 209
Assigning an Object to null is a code smell. Consider refactoring.105

zombies/gfx/GameMapPanel.java

ViolationLine
Perhaps 'scrollH' could be replaced by a local variable.41
Perhaps 'scrollV' could be replaced by a local variable.42
These nested if statements could be combined245 - 250

zombies/gfx/TilesetGfx.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method70

zombies/ZombieAttack.java

ViolationLine
Perhaps 'mapPanel' could be replaced by a local variable.48
It is a good practice to call super() in a constructor111 - 114
Avoid empty if statements203
Avoid empty if statements299