The following document contains the results of FindBugs Report
FindBugs Version is 1.1.1
Threshold is Normal
Effort is Max
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 266 | 18 | 0 | 3 |
| Class | Bugs |
|---|---|
| zombies.ZombieAttack | 2 |
| zombies.engine.cards.Weapon | 7 |
| zombies.engine.map.GameMap | 4 |
| zombies.gfx.TilesetGfx | 2 |
| zombies.gfx.TilesetLoader | 2 |
| zombies.util.PathUtil | 1 |
| Bug | Category | Details | Line |
|---|---|---|---|
| zombies.ZombieAttack.actionPerformed(java.awt.event.ActionEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 177 |
| Class zombies.ZombieAttack defines non-transient non-serializable instance field game | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unused field: zombies.engine.cards.Weapon.APtoShoot | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unused field: zombies.engine.cards.Weapon.APtoSmashBarricade | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unused field: zombies.engine.cards.Weapon.oopsLeft | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unused field: zombies.engine.cards.Weapon.secondWeapon | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unused field: zombies.engine.cards.Weapon.shotMaxDistance | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unused field: zombies.engine.cards.Weapon.shotMinDistance | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unused field: zombies.engine.cards.Weapon.splashMap | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| zombies.engine.map.GameMap.getHumans() may expose internal representation by returning zombies.engine.map.GameMap.humans | MALICIOUS_CODE | EI_EXPOSE_REP | 85 |
| zombies.engine.map.GameMap.getZombies() may expose internal representation by returning zombies.engine.map.GameMap.zombies | MALICIOUS_CODE | EI_EXPOSE_REP | 88 |
| zombies.engine.map.GameMap.setHumans(zombies.engine.critter.Human[]) may expose internal representation by storing an externally mutable object into zombies.engine.map.GameMap.humans | MALICIOUS_CODE | EI_EXPOSE_REP2 | 86 |
| zombies.engine.map.GameMap.setZombies(zombies.engine.critter.Zombie[]) may expose internal representation by storing an externally mutable object into zombies.engine.map.GameMap.zombies | MALICIOUS_CODE | EI_EXPOSE_REP2 | 89 |
| Bug | Category | Details | Line |
|---|---|---|---|
| zombies.gfx.TilesetGfx.TilesetGfx(String,int,int,TileGfx[][],java.awt.Image[][][],java.awt.Image) may expose internal representation by storing an externally mutable object into zombies.gfx.TilesetGfx.creatures | MALICIOUS_CODE | EI_EXPOSE_REP2 | 50 |
| zombies.gfx.TilesetGfx.TilesetGfx(String,int,int,TileGfx[][],java.awt.Image[][][],java.awt.Image) may expose internal representation by storing an externally mutable object into zombies.gfx.TilesetGfx.tiles | MALICIOUS_CODE | EI_EXPOSE_REP2 | 49 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method zombies.gfx.TilesetLoader.load(String,java.awt.MediaTracker) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 107 |
| Method zombies.gfx.TilesetLoader.load(String,java.awt.MediaTracker) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 119 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method zombies.util.PathUtil.extractPathInfo(String) invokes toString() method on a String; just use the String | PERFORMANCE | DM_STRING_TOSTRING | 29 |
